Commits on Dec 3, 2021

1. [api-minor] Clear all caches in XRef.indexObjects, and improve /Roo… …

   …t dictionary validation in `XRef.parse` (issue 14303)
   
   *This patch improves handling of a couple of PDF documents from issue 14303.*
   
    - Update `XRef.indexObjects` to actually clear *all* XRef-caches. Invalid XRef tables *usually* cause issues early enough during parsing that we've not populated the XRef-cache, however to prevent any issues we obviously need to clear that one as well.
   
    - Improve the /Root dictionary validation in `XRef.parse` (PR 9827 follow-up). In addition to checking that a /Pages entry exists, we'll now also check that it can be successfully fetched *and* that it's of the correct type. There's really no point trying to use a /Root dictionary that e.g. `Catalog.toplevelPagesDict` will reject, and this way we'll be able to fallback to indexing the objects in corrupt documents.
   
    - Throw an `InvalidPDFException`, rather than a general `FormatError`, in `XRef.parse` when no usable /Root dictionary could be found. That really seems more appropriate overall, since all attempts at parsing/recovery have failed. (This part of the patch is API-observable, hence the tag.)
   
   With these changes, two existing test-cases are improved and the unit-tests are updated/re-factored to highlight that. In particular `GHOSTSCRIPT-698804-1-fuzzed.pdf` will now both load and "render" correctly, whereas `poppler-395-0-fuzzed.pdf` will now fail immediately upon loading (rather than *appearing* to work).

   

   Snuffleupagus committed Dec 3, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for ad3a271
   • Browse repository at this point

   Copy the full SHA

   ad3a271 View commit details

   Browse the repository at this point in the history