Display background when printing or saving a text widget (issue #14928)

[calixteman]

No description provided.

[Snuffleupagus]

The shorter number format in the written data, especially for integer values, is a nice bonus of these changes!

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2797961af460b08/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bce91eeea18c62f/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/2797961af460b08/output.txt

Total script time: 25.88 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 534
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2797961af460b08/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/bce91eeea18c62f/output.txt

Total script time: 31.11 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 379

Image differences available at: http://54.193.163.58:8877/bce91eeea18c62f/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

There's a bunch of movement that looks unrelated to these changes, but I think that we need to run tests (and makeref) separately first such that we don't miss anything in this PR.

However, looking at the Windows results the reftest-analyzer appears to be broken since there's no clickable links anymore which makes checking for failures impossible. @calixteman Can you please see if the Windows bot need to update or restarted, or what's up with the reftest-analyzer being broken?

[calixteman]

There are a lot of errors:

TypeError: Cannot read property 'html_url' of undefined
    at C:\pdfjs\botio\lib\server.js:274:37
    at callbacks (C:\pdfjs\botio\node_modules\express\lib\router\index.js:272:11)
    at param (C:\pdfjs\botio\node_modules\express\lib\router\index.js:246:11)
    at pass (C:\pdfjs\botio\node_modules\express\lib\router\index.js:253:5)
    at Router._dispatch (C:\pdfjs\botio\node_modules\express\lib\router\index.js:280:5)
    at Object.Router.middleware [as handle] (C:\pdfjs\botio\node_modules\express\lib\router\index.js:45:10)
    at next (C:\pdfjs\botio\node_modules\connect\lib\http.js:204:15)
    at IncomingMessage.<anonymous> (C:\pdfjs\botio\node_modules\connect\lib\middleware\bodyParser.js:137:7)
    at IncomingMessage.emit (events.js:388:22)
    at endReadableNT (internal/streams/readable.js:1336:12)

and this property is read:
https://github.com/arturadib/botio/blob/master/lib/server.js#L272

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fbde573692618db/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e818f3b336c4d5d/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/e818f3b336c4d5d/output.txt

Total script time: 19.41 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  errors: 708
  different ref/snapshot: 9

Image differences available at: http://54.241.84.105:8877/e818f3b336c4d5d/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/fbde573692618db/output.txt

Total script time: 27.67 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/fbde573692618db/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

(It seems that Chrome timed-out on the Linux bot...)

Are all of these changes consistent with printing from e.g. Adobe Reader?
Looking at 160F-2019-page1, that one doesn't seem to include either border or background colors when printing from Adobe Reader (and that particular field isn't editable there).

[calixteman]

in 160F-2019.pdf, the colors of background and border are set thanks to JS in a WillPrint action and reset in DidPrint one.
But it won't work correctly because of:

pdf.js/web/app.js

Lines 1773 to 1774 in 3c877f9

	// Given that the "beforeprint" browser event is synchronous, we
	// unfortunately cannot await the scripting event dispatching here.

Anyway I began to add the color values in annotationStorage when they're modified by JS. If you're ok I'll make these changes in an other PR.
If you've a good idea to be able to wait for WillPrint results, please propose.

[calixteman]

/botio-linux browsertest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8e5951ef4272478/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/8e5951ef4272478/output.txt

Total script time: 21.66 mins

• Regression tests: FAILED

  different ref/snapshot: 13
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/8e5951ef4272478/reftest-analyzer.html#web=eq.log

[calixteman]

in 160F-2019.pdf, the colors of background and border are set thanks to JS in a WillPrint action and reset in DidPrint one. But it won't work correctly because of:

pdf.js/web/app.js

Lines 1773 to 1774 in 3c877f9

	// Given that the "beforeprint" browser event is synchronous, we
	// unfortunately cannot await the scripting event dispatching here.

Anyway I began to add the color values in annotationStorage when they're modified by JS. If you're ok I'll make these changes in an other PR. If you've a good idea to be able to wait for WillPrint results, please propose.

I'll try to fix that in a follow-up.

[Snuffleupagus]

Anyway I began to add the color values in annotationStorage when they're modified by JS. If you're ok I'll make these changes in an other PR.

Yeah, this one is probably large enough already so that sounds good to me.

If you've a good idea to be able to wait for WillPrint results, please propose.

Unfortunately not, since it seems to be a web-platform limitation given that printing is synchronous.
It seems that you'd really want async printing support (which as far as I understand doesn't exist on the web), since trying to somehow delay regular printing seems like it could easily cause lots of issues.

[Snuffleupagus]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d89f8cf45d25b64/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/1b473334dfcda68/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/d89f8cf45d25b64/output.txt

Total script time: 22.33 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/1b473334dfcda68/output.txt

Total script time: 21.72 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed