Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 'dropEffect' based on 'effectAllowed' for drag-and-drop in the viewer (issue 14942) #14948

Merged
merged 1 commit into from
May 22, 2022

Conversation

Pldi23
Copy link
Contributor

@Pldi23 Pldi23 commented May 21, 2022

Issue #14942

Applied the solution suggested in comments

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the standard names in the commit message, since that seems a little clearer. And please also include a link to https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/effectAllowed in the commit message.

E.g. with the commit message looking something like this:

Set `dropEffect` based on `effectAllowed` for drag-and-drop in the viewer (issue 14942)

See https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/effectAllowed

web/app.js Outdated Show resolved Hide resolved
@Pldi23 Pldi23 force-pushed the drag&drop_not_work_from_mail branch 2 times, most recently from 066721c to 9f0995d Compare May 22, 2022 05:48
@Snuffleupagus Snuffleupagus changed the title set drop effect based on effect allowed value Set 'dropEffect' based on 'effectAllowed' for drag-and-drop in the viewer (issue 14942) May 22, 2022
@Pldi23 Pldi23 force-pushed the drag&drop_not_work_from_mail branch from b1941f8 to 55da67e Compare May 22, 2022 12:58
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@Snuffleupagus
Copy link
Collaborator

/botio-windows preview

@calixteman
Copy link
Contributor

@mozilla mozilla deleted a comment from pdfjsbot May 22, 2022
@mozilla mozilla deleted a comment from pdfjsbot May 22, 2022
@mozilla mozilla deleted a comment from pdfjsbot May 22, 2022
@mozilla mozilla deleted a comment from pdfjsbot May 22, 2022
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented May 22, 2022

Some double quotes are likely missing here: https://github.com/HorizenOfficial/botio/blob/0cf5a068d8c534b518577be1d2b2ae2895581f81/lib/module.js#L107

Or perhaps in https://github.com/arturadib/botio/blob/master/lib/module.js, which I believe is what powers https://github.com/mozilla/botio-files-pdfjs

Edit: Anyway, I've quickly tested the patch locally instead :-)

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop pdf document when dragging from mail app do not work
3 participants