-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set 'dropEffect' based on 'effectAllowed' for drag-and-drop in the viewer (issue 14942) #14948
Set 'dropEffect' based on 'effectAllowed' for drag-and-drop in the viewer (issue 14942) #14948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use the standard names in the commit message, since that seems a little clearer. And please also include a link to https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/effectAllowed in the commit message.
E.g. with the commit message looking something like this:
Set `dropEffect` based on `effectAllowed` for drag-and-drop in the viewer (issue 14942)
See https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/effectAllowed
066721c
to
9f0995d
Compare
b1941f8
to
55da67e
Compare
/botio-linux preview |
/botio-windows preview |
Some double quotes are likely missing here: |
Or perhaps in https://github.com/arturadib/botio/blob/master/lib/module.js, which I believe is what powers https://github.com/mozilla/botio-files-pdfjs Edit: Anyway, I've quickly tested the patch locally instead :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Issue #14942
Applied the solution suggested in comments