[JS] Format all the fields if any when the document is open (bug 1766987) #14950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
calixteman
commented
May 22, 2022
calixteman
commented
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1766987.
|
I'll add an integration test. |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/04791fda5ffd5ff/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8ca3589ba8e9394/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/04791fda5ffd5ff/output.txt Total script time: 4.45 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8ca3589ba8e9394/output.txt Total script time: 6.96 mins
|
Snuffleupagus
approved these changes
May 22, 2022
calixteman
added a commit
to calixteman/pdf.js
that referenced
this pull request
Dec 13, 2022
… open (issue mozilla#15818) It's a follow-up of mozilla#14950: some format actions are ran when the document is open but we must be sure we've everything ready for that, hence we have to run some named actions before runnig the global format. In playing with the form, I discovered that the blur event wasn't triggered when JS called `setFocus` (because in such a case the mouse was never down). So I removed the mouseState thing to just use the correct commitKey when blur is triggered by a TAB key.
calixteman
added a commit
to calixteman/pdf.js
that referenced
this pull request
Dec 13, 2022
… open (issue mozilla#15818) It's a follow-up of mozilla#14950: some format actions are ran when the document is open but we must be sure we've everything ready for that, hence we have to run some named actions before runnig the global format. In playing with the form, I discovered that the blur event wasn't triggered when JS called `setFocus` (because in such a case the mouse was never down). So I removed the mouseState thing to just use the correct commitKey when blur is triggered by a TAB key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.