-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom pageColors
in the thumbnails (PR 14874)
#14959
Support custom pageColors
in the thumbnails (PR 14874)
#14959
Conversation
Currently, when non-standard `pageColors` are specified, the thumbnails will look inconsistent depending on how they're created. The thumbnails that are created by downsizing the *page* canvases will obviously use the `pageColors` as intended, however the thumbnails which are rendered *directly* will always use the default colors.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e35d3b90ecdb82e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e35d3b90ecdb82e/output.txt Total script time: 2.54 mins Published |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ea3a753bca7560e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3f4d81d024c08e2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ea3a753bca7560e/output.txt Total script time: 4.90 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3f4d81d024c08e2/output.txt Total script time: 7.44 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Currently, when non-standard
pageColors
are specified, the thumbnails will look inconsistent depending on how they're created.The thumbnails that are created by downsizing the page canvases will obviously use the
pageColors
as intended, however the thumbnails which are rendered directly will always use the default colors.