Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use globalThis for webpack's output.globalObject instead of this #14966

Merged
merged 1 commit into from
May 29, 2022
Merged

Use globalThis for webpack's output.globalObject instead of this #14966

merged 1 commit into from
May 29, 2022

Conversation

tamuratak
Copy link
Contributor

Use globalThis for webpack's output.globalObject instead of this. Close #14915.

That allows us to import pdfjs-dist/build/pdf.js dynamically from modules.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.241.84.105:8877/5273ae9589ef1d5/output.txt

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 3

Live output at: http://54.241.84.105:8877/e13c03cde39284b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/ce9141617dae4c7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5273ae9589ef1d5/output.txt

Total script time: 2.61 mins

Published

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e13c03cde39284b/output.txt

Total script time: 26.58 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 24
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/e13c03cde39284b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ce9141617dae4c7/output.txt

Total script time: 28.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

Snuffleupagus
Snuffleupagus approved these changes May 29, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this, since everything still appears to work as it should; thank you!

@Snuffleupagus Snuffleupagus merged commit 0d3a5d7 into mozilla:master May 29, 2022
@tamuratak tamuratak deleted the use_globalthis branch November 13, 2023 03:44
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@earthywh earthywh mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use globalThis for webpack's output.globalObject instead of this
3 participants
@tamuratak @Snuffleupagus @pdfjsbot