Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CSS-comments better in the preprocess-function (PR 14963 follow-up) #14980

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

This fixes another oversight, please see the updated tests.

…w-up)

This fixes another oversight, please see the updated tests.
@mozilla mozilla deleted a comment from pdfjsbot Jun 2, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jun 2, 2022
@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2022

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8ce2f4c31d949d7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8ce2f4c31d949d7/output.txt

Total script time: 2.68 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@calixteman
Copy link
Contributor

Out of curiosity, did you build and run on m-c in order to be sure that everything is ok ?

@Snuffleupagus
Copy link
Collaborator Author

Out of curiosity, did you build and run on m-c in order to be sure that everything is ok ?

Yes, I diffed the output of gulp mozcentral with/without this patch for the built web/viewer.css and web/viewer.html files.
As expected, there were no changes caused by this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants