Enable the unicorn/prefer-at ESLint plugin rule (PR 15008 follow-up)

[Snuffleupagus]

Please find additional information here:

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at
• https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-at.md

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/48ef401c6ded304/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/906c8221b051539/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/48ef401c6ded304/output.txt

Total script time: 25.97 mins

• Font tests: Passed
• Unit tests: FAILED
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 40
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/48ef401c6ded304/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/906c8221b051539/output.txt

Total script time: 28.13 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/906c8221b051539/reftest-analyzer.html#web=eq.log

[timvandermeij]

Hm, the PR looks good to me, but on Linux I'm seeing a lot of movement in the Tracemonkey images that I didn't see in other PRs that were landed today/yesterday. Did something regress here or are we just unfortunate to run into an upstream defect just now (I triggered a build in #14940 to make sure)?

[Snuffleupagus]

Did something regress here or are we just unfortunate to run into an upstream defect just now (I triggered a build in #14940 to make sure)?

Most likely, it's still https://bugzilla.mozilla.org/show_bug.cgi?id=1770088 that's the culprit here.

[timvandermeij]

Thanks! Hopefully that upstream bug gets resolved soon.