Expose TextLayerRenderTask in the TypeScript definitions (issue 15016, PR 14013 follow-up)
#15018
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
TextLayerRenderTask in TypeScript definitions (issue 15016, PR 14013 follow-up)TextLayerRenderTask in the TypeScript definitions (issue 15016, PR 14013 follow-up)
Snuffleupagus
force-pushed
the
issue-15016
branch
from
520d45a
to
380299e
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/897ec7e3ae60e7b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cab6674c01397db/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/897ec7e3ae60e7b/output.txt Total script time: 3.31 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cab6674c01397db/output.txt Total script time: 6.64 mins
|
Snuffleupagus
force-pushed
the
issue-15016
branch
from
380299e
to
e0e8d91
Compare
…16, PR 14013 follow-up) While `TextLayerRenderTask` apparently makes sense in TypeScript environments, given that it's being returned by the `renderTextLayer`-function in the API, we really don't want to extend the *public* API by simply exporting the class directly in `src/pdf.js` since it should never be called/initialized manually. Hence we follow the same pattern as in PR 14013, and add some very basic unit-tests to ensure that `renderTextLayer` always returns a `TextLayerRenderTask`-instance as expected.
Snuffleupagus
force-pushed
the
issue-15016
branch
from
e0e8d91
to
e046b81
Compare
timvandermeij
approved these changes
Jun 10, 2022
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
TextLayerRenderTaskapparently makes sense in TypeScript environments, given that it's being returned by therenderTextLayer-function in the API, we really don't want to extend the public API by simply exporting the class directly insrc/pdf.jssince it should never be called/initialized manually.Hence we follow the same pattern as in PR #14013, and add some very basic unit-tests to ensure that
renderTextLayeralways returns aTextLayerRenderTask-instance as expected.