[api-minor] Stop using the beginAnnotations/endAnnotations operators (PR 14998 follow-up)
#15026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors (PR 14998 follow-up) After the changes in PR 14998, these operators are now no-ops in the `src/display/canvas.js` code and should no longer be necessary. Given that `beginAnnotations`/`endAnnotations` are not in the PDF specification, but are rather *custom* PDF.js operators, it seems reasonable to stop using them now that they've become no-ops.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2a557fdf04bd78b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b25937548f9dc30/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b25937548f9dc30/output.txt Total script time: 26.24 mins
Image differences available at: http://54.241.84.105:8877/b25937548f9dc30/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2a557fdf04bd78b/output.txt Total script time: 28.46 mins
Image differences available at: http://54.193.163.58:8877/2a557fdf04bd78b/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes in PR #14998, these operators are now no-ops in the
src/display/canvas.jscode and should no longer be necessary.Given that
beginAnnotations/endAnnotationsare not in the PDF specification, but are rather custom PDF.js operators, it seems reasonable to stop using them now that they've become no-ops.