Use modern DOM methods a bit more (PR 15031 follow-up) #15035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the ESLint rule added in PR 15031 wasn't able to catch all cases that can be converted, which is probably not all that surprising given how some of these call-sites look. - Use `Element.prepend()` to insert nodes before all other ones in the element, rather than using `firstChild` with `insertBefore`-calls; see https://developer.mozilla.org/en-US/docs/Web/API/Element/prepend - Fix one *incorrect* `insertBefore` call, in the AnnotationLayer-code. Initially the patch simply changed that to an `Element.before()`-call, however that broke one of the integration-tests. It turns out that the `index` may try to access a non-existent select-child, which triggers undefined behaviour; note the warning in https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore#parameters
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d0c1ba57aebfb83/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f82ac5eb4dcd447/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f82ac5eb4dcd447/output.txt Total script time: 26.04 mins
Image differences available at: http://54.241.84.105:8877/f82ac5eb4dcd447/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d0c1ba57aebfb83/output.txt Total script time: 28.11 mins
Image differences available at: http://54.193.163.58:8877/d0c1ba57aebfb83/reftest-analyzer.html#web=eq.log |
calixteman
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the ESLint rule added in PR #15031 wasn't able to catch all cases that can be converted, which is probably not all that surprising given how some of these call-sites look.
Use
Element.prepend()to insert nodes before all other ones in the element, rather than usingfirstChildwithinsertBefore-calls; see https://developer.mozilla.org/en-US/docs/Web/API/Element/prependFix one incorrect
insertBeforecall, in the AnnotationLayer-code.Initially the patch simply changed that to an
Element.before()-call, however that broke one of the integration-tests. It turns out that theindexmay try to access a non-existent select-child, which triggers undefined behaviour; note the warning in https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore#parameters