Ensure that the annotationLayer has the correct dimensions (PR 15036 follow-up) #15069
Conversation
…follow-up) Note how the "page"-div, "canvasWrapper"-div, and `textLayer`-div all have *integer* dimensions (rounded down) rather than using the "raw" viewport-dimensions. Hence it seems reasonable that the same should apply to the "annotationLayer"-div, now that it's explicit dimensions set.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/67f06d77563854c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c2d548d1c8800c1/output.txt |
|
Do we need to have the "exact" width/height in the viewport ? If not, we could just store the floored values, wdyt ? |
I'd be somewhat nervous about making that sort of change, since the current behaviour has existing since "forever" and changing it would require going through and (often manually) testing lots of code.
As a start, we could perhaps also provide the floored dimensions directly on |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/67f06d77563854c/output.txt Total script time: 26.22 mins
Image differences available at: http://54.241.84.105:8877/67f06d77563854c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c2d548d1c8800c1/output.txt Total script time: 28.84 mins
Image differences available at: http://54.193.163.58:8877/c2d548d1c8800c1/reftest-analyzer.html#web=eq.log |
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/467e85150c03528/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8bcdb720d99955b/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8bcdb720d99955b/output.txt Total script time: 21.48 mins
Image differences available at: http://54.193.163.58:8877/8bcdb720d99955b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/467e85150c03528/output.txt Total script time: 22.08 mins
Image differences available at: http://54.241.84.105:8877/467e85150c03528/reftest-analyzer.html#web=eq.log |
|
In debugging some code I noticed: |
Given that we're using |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/1cca1343973603f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/901be1a97d2d83c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/901be1a97d2d83c/output.txt Total script time: 22.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1cca1343973603f/output.txt Total script time: 22.06 mins
|
Note how the "page"-div, "canvasWrapper"-div, and
textLayer-div all have integer dimensions (rounded down) rather than using the "raw" viewport-dimensions.Hence it seems reasonable that the same should apply to the "annotationLayer"-div, now that it's explicit dimensions set.