[editor] Introduce a proper annotationEditorMode option/preference (PR 15075 follow-up)

[Snuffleupagus]

• [editor] Introduce a proper annotationEditorMode option/preference (PR 15075 follow-up)

  This replaces the boolean annotationEditorEnabled option/preference with a "proper" annotationEditorMode one. This way it's not only possible for the user to control if Editing is enabled/disabled, but also which specific Editing-mode should become enabled upon PDF document load.

  Given that Editing is not enabled/released yet, I cannot imagine that changing the name and type of the option/preference should be an issue.

• [editor] Remove the unused name-property from the editorParamsToolbars DOM elements

  As far as I can tell, this is completely unused and can thus be removed.

• [editor] Slightly shorten the en-US freetext_default_content placeholder text

  Now that it's possible to change the font-size, this placeholder string feels a little bit long (especially for larger font-sizes).

  Given that Editing is not enabled/released yet, I hope that it should be fine to update this without changing the l10n-id.

[calixteman]

LGTM, thank you.

[Snuffleupagus]

/botio integrationtest

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1365024cc0d6936/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8c26b2eded5e1fa/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/8c26b2eded5e1fa/output.txt

Total script time: 4.72 mins

• Integration Tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/1365024cc0d6936/output.txt

Total script time: 7.59 mins

• Integration Tests: FAILED

[calixteman]

@Snuffleupagus, there is a leftover:

pdf.js/web/app_options.js

Line 44 in ce63663

compatibilityParams.annotationEditorEnabled = false;

[Snuffleupagus]

@Snuffleupagus, there is a leftover:

pdf.js/web/app_options.js

Line 44 in ce63663

compatibilityParams.annotationEditorEnabled = false;

Oops; I'll fix that, and also ensure that the default value is handled correctly in the BaseViewer-constructor. (Thankfully all of this only matters for old and outdated Safari.)