[Editor] Allow to select a freetext editor when in ink mode #15118
Conversation
src/display/editor/tools.js
Outdated
| if (mode === this.#mode) { | ||
| return; | ||
| } | ||
| this.#eventBus?.dispatch("switchannotationeditormode", { |
There was a problem hiding this comment.
I'd probably argue that the #eventBus being undefined here is a bug in code that's initializing the AnnotationEditor; so you might be able to simply assume that it's available?
There was a problem hiding this comment.
I just copied that from annotation_layer.js (linkService.eventBus?...)
There was a problem hiding this comment.
There's one difference here: The annotationLayer had existed, for years, before it started depending on the eventBus. Hence we wanted to prevent outright errors in existing third-party code, when users updated to a new release.
For the annotationEditorLayer, which is completely new (and still unreleased) functionality, it should be fine to always assume that the eventBus is available.
- and when in ink mode, change the toolbar active button when a freetext edited.
calixteman
force-pushed
the
editor_selection
branch
from
3078527
to
a694e36
Compare
|
/botio integrationtest |
1 similar comment
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2b225f8bba56e05/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/783e34373360e5c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2b225f8bba56e05/output.txt Total script time: 4.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/783e34373360e5c/output.txt Total script time: 7.67 mins
|
a freetext edited.