Call AnnotationLayer.setDimensions as part of the render/update-methods (PR 15036 follow-up)
#15124
Conversation
…-methods (PR 15036 follow-up)
Rather than forcing the user to *manually* call `setDimensions`, which is also breaking any existing third-party code, it seems that we can simply let the `AnnotationLayer.{render, update}`-methods handle that internally.
As far as I can tell, based on testing manually in the viewer *and* running the browser-tests, everything still appears to work correctly with this patch.
Snuffleupagus
force-pushed
the
private-setDimensions
branch
from
7b88240
to
552ee9d
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/588fd498961f13c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/999e0e2dad0a278/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/999e0e2dad0a278/output.txt Total script time: 10.22 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/588fd498961f13c/output.txt Total script time: 25.99 mins
Image differences available at: http://54.241.84.105:8877/588fd498961f13c/reftest-analyzer.html#web=eq.log |
|
/botio-windows browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3c6bd895bb4cad0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3c6bd895bb4cad0/output.txt Total script time: 21.42 mins
|
Rather than forcing the user to manually call
setDimensions, which is also breaking any existing third-party code, it seems that we can simply let theAnnotationLayer.{render, update}-methods handle that internally.As far as I can tell, based on testing manually in the viewer and running the browser-tests, everything still appears to work correctly with this patch.