Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsdoc] failing typescript builds - wrong type #15143

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[jsdoc] failing typescript builds - wrong type #15143

merged 1 commit into from
Jul 7, 2022

Conversation

bernatgy
Copy link
Contributor

@bernatgy bernatgy commented Jul 7, 2022

HTMLSectionElement is not part of the DOM, so the generated typescript definitions contain a non-existing type.

HTML Section elements have to be handled as simple HTMLElements.

src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Outdated Show resolved Hide resolved
`HTMLSectionElement` is not part of the DOM, so the generated typescript definitions contain a non-existing type.

HTML Section elements have to be handled as simple `HTMLElements`.

fixing punctuation and lint problems

[jsdoc] failing typescript builds - wrong type
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@Snuffleupagus Snuffleupagus merged commit d6a7526 into mozilla:master Jul 7, 2022
@bernatgy bernatgy deleted the typescript-compilation-fix branch July 7, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants