Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ttx from version 2.5 to version 3.19.0 #15158

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Jul 10, 2022

The current version 2.5 is from September 2014, which is almost 8 years old now. The new version 3.19.0 is from November 2017, which is still almost 5 years old, but is a step forward towards eventually using the most recent version. Note that we currently can't update any further; see #11802 for the details.

Fortunately using this newer version only required a few changes:

  • The ttx output regexes needed updating to ignore comments that ttx now puts after some XML nodes (<!-- ... --> and /* ... */).
  • The ttx invocation now explicitly uses python2 since otherwise the font tests can't be run on modern systems anymore given that python is nowadays an alias for python3, and it now points at the new location of the ttx.py file since the Tools folder got removed.
  • The note about needing a 32-bit Python 2.6 version is dropped since it's obsolete: this version (and also the existing one already) work just fine on a 64-bit Python 2.7 as well.

Fixes a part of #11802.

@timvandermeij
Copy link
Contributor Author

/botio fonttest

@timvandermeij
Copy link
Contributor Author

/botio fonttest

@timvandermeij
Copy link
Contributor Author

/botio-windows fonttest

@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@timvandermeij
Copy link
Contributor Author

/botio fonttest

The current version 2.5 is from September 2014, which is almost 8 years
old now. The new version 3.19.0 is from November 2017, which is still
almost 5 years old, but is a step forward towards eventually using the
most recent version. Note that we currently can't update any further;
see mozilla#11802 for the details.

Fortunately using this newer version only required a few changes:

- The `ttx` output regexes needed updating to ignore comments that `ttx`
  now puts after some XML nodes (`<!-- ... -->` and `/* ... */`).
- The `ttx` invocation now explicitly uses `python2` (except on Windows
  where this alias doesn't exist) since otherwise the font tests can't
  be run on modern systems anymore given that `python` is nowadays an
  alias for `python3`, and it now points at the new location of the
  `ttx.py` file since the `Tools` folder got removed.
- The note about needing a 32-bit Python 2.6 version is dropped since
  it's obsolete: this version (and also the existing one already) work
  just fine on a 64-bit Python 2.7 as well.
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jul 10, 2022
@timvandermeij
Copy link
Contributor Author

/botio fonttest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_fonttest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2614f6b85e9b7c9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_fonttest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eb88db23235965e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/eb88db23235965e/output.txt

Total script time: 1.62 mins

  • Font Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/2614f6b85e9b7c9/output.txt

Total script time: 3.42 mins

  • Font Tests: Passed

@Snuffleupagus
Copy link
Collaborator

/botio fonttest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/06cb5771eb4109b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a08254c6b149d0e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/06cb5771eb4109b/output.txt

Total script time: 1.61 mins

  • Font Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/a08254c6b149d0e/output.txt

Total script time: 3.38 mins

  • Font Tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@Snuffleupagus Snuffleupagus merged commit e572bc4 into mozilla:master Jul 11, 2022
@timvandermeij timvandermeij deleted the ttx branch July 16, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants