Handle errors in the "Loading by ref" code-path in PartialEvaluator.loadFont
#15169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1a668379f9c712a/output.txt |
calixteman
reviewed
Jul 15, 2022
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1a668379f9c712a/output.txt Total script time: 29.98 mins
Image differences available at: http://54.193.163.58:8877/1a668379f9c712a/reftest-analyzer.html#web=eq.log |
…loadFont` Note how we currently throw a "raw" Error, which is problematical since all of the `PartialEvaluator.loadFont` call-sites expect a Promise to be returned. Furthermore, this also means that we don't benefit from the fallback code-path that now exists below. *Please note:* Unfortunately I don't have a test-case that fails without this patch, since it's something I happened to notice when reading the code while working on another patch.
Snuffleupagus
force-pushed
the
loadFont-fontRef
branch
from
436c913
to
acd61a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note how we currently throw a "raw" Error, which is problematical since all of the
PartialEvaluator.loadFontcall-sites expect a Promise to be returned. Furthermore, this also means that we don't benefit from the fallback code-path that now exists below.Please note: Unfortunately I don't have a test-case that fails without this patch, since it's something I happened to notice when reading the code while working on another patch.