Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Deprecate the SVG back-end #15173

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

Given that the SVG back-end is not defined anywhere except in GENERIC builds, we can remove a little bit more unnecessary code in e.g. the Firefox PDF Viewer.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fadbde008f0cd58/output.txt

@timvandermeij
Copy link
Contributor

Hm, do you know why the Linux bot is not triggered here?

@Snuffleupagus
Copy link
Collaborator Author

Hm, do you know why the Linux bot is not triggered here?

It might be unrelated but the bots were updated the other day since their Node.js versions were old, so they should now be using the current LTS release, and it seems that (anecdotally) the Linux bot has been a little bit flaky since then.

@calixteman
Copy link
Contributor

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0ad4cb7be75ffe5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/fadbde008f0cd58/output.txt

Total script time: 29.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/0ad4cb7be75ffe5/output.txt

Total script time: 25.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/0ad4cb7be75ffe5/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 5bfba89 into mozilla:master Jul 17, 2022
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the deprecated-svg branch July 17, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants