[Editor] Simplify the way to create an editor on click #15184
Conversation
|
And it should help to fix an issue with integration test in #15110. |
| return; | ||
| } | ||
|
|
||
| this.#createAndAddNewEditor(event); | ||
| } | ||
|
|
||
| /** | ||
| * Mouseclick callback. |
There was a problem hiding this comment.
This looks like too much copy-and-paste from the method above, since I assume that you actually want:
| * Mouseclick callback. | |
| * Mousedown callback. |
| /** | ||
| * Mouseclick callback. | ||
| * @param {MouseEvent} event | ||
| * @returns {undefined} |
There was a problem hiding this comment.
Let's not add any more of these "returns undefined" JSDoc-comments, since you're removing the existing ones in another PR.
Previously, we had to set the #allowClick property by hand which was a bit painful because it's easy to overlook one case or an other. So with this patch a new editor (for now FreeText one only because the Ink one is a bit different) is created on the first click if none is selected on mousedown, else the first click will just commit the data and then the second will creater a new editor.
calixteman
force-pushed
the
rm_allowclick
branch
from
ae8405b
to
7024a53
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/82cc8f694c4c1c5/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d4e1bb55b131ac8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d4e1bb55b131ac8/output.txt Total script time: 4.50 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/82cc8f694c4c1c5/output.txt Total script time: 9.89 mins
|
Previously, we had to set the #allowClick property by hand which was
a bit painful because it's easy to overlook one case or an other.
So with this patch a new editor (for now FreeText one only because the
Ink one is a bit different) is created on the first click if none is selected
on mousedown, else the first click will just commit the data and then the
second will creater a new editor.