[Editor] Replace mouse events by pointer ones (bug 1779015) #15188
Conversation
|
If you want to test drag and drop in firefox, you must double tap on an element and then quickly start dragging it. |
| @@ -224,7 +224,7 @@ class AnnotationEditor { | |||
| this.div.setAttribute("data-editor-rotation", (360 - this.rotation) % 360); | |||
| this.div.className = this.name; | |||
| this.div.setAttribute("id", this.id); | |||
| this.div.tabIndex = 0; | |||
There was a problem hiding this comment.
I'm not sure why this was changed, since there ought to be no practical difference?
There was a problem hiding this comment.
I can't explain why.
I tested the patch on laptop with a touch screen and it was almost impossible to create a text editor in just tapping on the screen.
My feeling was that the div stole the focus from the nested editorDiv and then removed the editor.
So I just removed the tabindex and magically it worked.
There was a problem hiding this comment.
So I just removed the tabindex and magically it worked.
But it's still being set, but slightly differently now; hence my question :-)
There was a problem hiding this comment.
Oh I thought it was just a removal in taking into account the context gh gives me here, and I was finally talking about this removal:
https://github.com/mozilla/pdf.js/pull/15188/files/b408d0e0abfd7d8c98e2befc82a7d4027e5d84e0#diff-8545c7e2bc39439352001789060a1bb9a42fc64e599c34322be45102ae3e7d08L221
Anyway you're right the change here is useless, but if iirc it was to be consistent with the line just above.
And I'm not sure the setAttribute on the above line is useful either.
The goal is to be able to edit a pdf on a touchscreen.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/17637ef23d3ce39/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/311916f28e2efc3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/311916f28e2efc3/output.txt Total script time: 4.69 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/17637ef23d3ce39/output.txt Total script time: 6.71 mins
|
|
The multi-selection stuff is not working on touch screens because the event order is not exactly the same. |
The goal is to be able to edit a pdf on a touchscreen.