[api-minor] Improve how we disable PDFThumbnailView.setImage for documents with Optional Content
#15215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods To ensure that this data cannot be directly changed from the outside, use private fields/methods now that those are available.
Snuffleupagus
force-pushed
the
optional-content-initial
branch
from
be21d36
to
e9120f3
Compare
|
/botio integrationtest |
…e "outside" Given that Optional Content visibility is only intended/supported to be updated via the `OptionalContentConfig.setVisibility`-method, this patch actually enforces that now. Note that this will be used by the next patch in the series, and will help prevent inconsistent state in the `OptionalContentConfig`-class. *Please note:* This patch also uncovered a pre-existing bug, related to iterating through the visibility groups in the constructor, for the `baseState === "OFF"` case.
…he initial Optional Content visibility state This will allow us to improve the `PDFThumbnailView.setImage` handling in the viewer, and thanks to the added caching this should be reasonbly efficient.
… Optional Content (PR 12170 follow-up) Rather than always disable `PDFThumbnailView.setImage` as soon as user has changed the visibility of the Optional Content, we can utilize the new method added in the previous patch to improve thumbnail performance. Note in particular how, in the old code, even *resetting* of the Optional Content to its default state wouldn't enable `PDFThumbnailView.setImage` again. While slightly unrelated, this patch also removes the `PDFThumbnailViewer._optionalContentConfigPromise`-property since it's completely unused.
This code is completely unnecessary in e.g. the Firefox PDF Viewer.
Snuffleupagus
force-pushed
the
optional-content-initial
branch
from
dc84310
to
37dc0e7
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1f36ee9bec8cfc3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b16d1fb576842b5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1f36ee9bec8cfc3/output.txt Total script time: 25.65 mins
Image differences available at: http://54.241.84.105:8877/1f36ee9bec8cfc3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b16d1fb576842b5/output.txt Total script time: 29.09 mins
Image differences available at: http://54.193.163.58:8877/b16d1fb576842b5/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional information.
Note that I'm not sure if the second commit is actually necessary, and it may quite frankly be overkill here. (More generally I think it's interesting, since it shows one way of effectively making a method "private" despite it still being available from the outside.)