Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Simplify the strings for the tools in the UI #15217

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Jul 24, 2022 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jul 24, 2022

How wide can these containers potentially become, for the locale with the longest l10n strings?
Because if it's significantly more than the intended width, i.e. 220 px, then we probably need to implement wrapping of these toolbar-elements (similar to e.g. the secondaryToolbar).

@calixteman
Copy link
Contributor Author

I think we just remove the first word: "Line" or "Font", they're a bit redundant with what the tool is supposed to do.
Or we could have something like:

| Line thickness...................................|
| -o-----------------------------.|
| ...............................................................|
| Line color...........................................|
...

@Snuffleupagus
Copy link
Collaborator

I think we just remove the first word: "Line" or "Font", they're a bit redundant with what the tool is supposed to do.

I really like that idea!

@calixteman calixteman changed the title [Editor] Fix the width of the container containing some editor params [Editor] Simplify the strings for the tools in the UI Jul 28, 2022
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ec13c508686b3f1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ec13c508686b3f1/output.txt

Total script time: 2.44 mins

Published

@Snuffleupagus Snuffleupagus merged commit b06d190 into mozilla:master Jul 28, 2022
@calixteman calixteman deleted the 15216 branch July 28, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Area to set line thickness is not large enough
3 participants