[Editor] Avoid to add unexpected commands in the undo/redo queue when undoing/redoing (bug 1781790) #15233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… undoing/redoing (bug 1781790) We can undo/redo a command which will at some point add a command in the queue: typically it can happening when redoing an addition. So the idea is to lock the queue when undoing/redoing.
Snuffleupagus
approved these changes
Jul 27, 2022
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b073d1b2ca83dd2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cc78c826b97e71f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b073d1b2ca83dd2/output.txt Total script time: 4.95 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cc78c826b97e71f/output.txt Total script time: 11.77 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can undo/redo a command which will at some point add a command in the queue: typically
it can happening when redoing an addition.
So the idea is to lock the queue when undoing/redoing.