Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotations] Add some aria-owns in the text layer to link to annotations (bug 1780375) #15237

Merged
merged 1 commit into from
Aug 12, 2022

Commits on Aug 12, 2022

  1. [Annotations] Add some aria-owns in the text layer to link to annotat…

    …ions (bug 1780375)
    
    This patch doesn't structurally change the text layer: it just adds some aria-owns
    attributes to some spans.
    The aria-owns attribute expect to have an element id, hence it's why it adds back an
    id on the element rendering an annotation, but this id is built in using crypto.randomUUID
    to avoid any potential issues with the hash in the url.
    The elements in the annotation layer are moved into the DOM in order to have them in the
    same "order" as they visually are.
    The overall goal is to help screen readers to present to the user the annotations as
    they visually are and as they come in the text flow.
    It is clearly not perfect, but it should improve readability for some people with visual
    disabilities.
    calixteman committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    f316300 View commit details
    Browse the repository at this point in the history