Don't include images/toolbarButton-editorInk.svg in the gulp components build (issue 15260)
#15261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents` build (issue 15260) Given that this image is intended specifically for the default viewer, we simply use the CSS preprocessor to remove the image reference in the `gulp components` build. Considering that the issue only affects a CSS file, I don't believe that replacing the *just released* PDF.js version is actually necessary here.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/51a6ea812f15c6f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a325bb0dbbde679/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a325bb0dbbde679/output.txt Total script time: 4.83 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/51a6ea812f15c6f/output.txt Total script time: 11.45 mins
|
manlao
approved these changes
Aug 3, 2022
timvandermeij
approved these changes
Aug 6, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this image is intended specifically for the default viewer, we simply use the CSS preprocessor to remove the image reference in the
gulp componentsbuild.Considering that the issue only affects a CSS file, I don't believe that replacing the just released PDF.js version is actually necessary here.