[Editor] A pasted FreeText editor was missing when printing/saving #15274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
approved these changes
Aug 4, 2022
Comment on lines
38
to
39
| window.PDFViewerApplication.pdfDocument.annotationStorage._storage | ||
| .size |
There was a problem hiding this comment.
There's already an official getter for this, so please don't access a "private" property like this (since that'll break if we convert AnnotationStorage to actual private properties).
Suggested change
| window.PDFViewerApplication.pdfDocument.annotationStorage._storage | |
| .size | |
| window.PDFViewerApplication.pdfDocument.annotationStorage.size |
When a FreeText editor is pasted then it hasn't an editorDiv yet when added to the layer, hence it's empty. So this patch just move the call to addToAnnotationStorage to ensure we've what we need.
calixteman
force-pushed
the
missing_annotation
branch
from
96c712f
to
3c8d8f0
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1188056854f00ae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e649cef9a596faa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1188056854f00ae/output.txt Total script time: 4.99 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e649cef9a596faa/output.txt Total script time: 7.76 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a FreeText editor is pasted then it hasn't an editorDiv yet when added
to the layer, hence it's empty.
So this patch just move the call to addToAnnotationStorage to ensure we've
what we need.