Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTS issue with empty index (#15289) #15290

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

Comment on lines 6886 to 6893
{ "id": "issue15289.pdf",
"file": "pdfs/issue15289.pdf",
"md5": "f3d20aee398e052ac3dce7cc030f50de",
"link": true,
"rounds": 1,
"firstPage": 1,
"lastPage": 1,
"type": "eq"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Slightly weird indentation here (and we probably don't need "pdf" in the test-id).

Suggested change
{ "id": "issue15289.pdf",
"file": "pdfs/issue15289.pdf",
"md5": "f3d20aee398e052ac3dce7cc030f50de",
"link": true,
"rounds": 1,
"firstPage": 1,
"lastPage": 1,
"type": "eq"
{ "id": "issue15289",
"file": "pdfs/issue15289.pdf",
"md5": "f3d20aee398e052ac3dce7cc030f50de",
"link": true,
"rounds": 1,
"lastPage": 1,
"type": "eq"

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0ac8a22ebff753b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/27c76a62a337f81/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/0ac8a22ebff753b/output.txt

Total script time: 26.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/0ac8a22ebff753b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/27c76a62a337f81/output.txt

Total script time: 28.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman merged commit 589f72e into mozilla:master Aug 8, 2022
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a02aabd349c2e90/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/55910a5cfe75600/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a02aabd349c2e90/output.txt

Total script time: 22.05 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/55910a5cfe75600/output.txt

Total script time: 22.70 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing squares with hex values instead of text in some PDFs
3 participants