Move the reset-calls to occur last in the toolbar-constructors
#15296
Conversation
|
@calixteman I believe that this should get rid of the soft-reload issues you've encountered. /botio-linux preview |
By invoking the `reset` methods *last* in the `Toolbar`/`SecondaryToolbar`-constructors, we ensure that the "toolbarreset"/"secondarytoolbarreset"-events are actually handle when the viewer loads. Note that previously those events were dispatched *before* the relevant event-listeners had been attached. With this small change we can avoid inconsistent initial toolbar-state, specifically in the case when the viewer is *reloaded* (since Firefox keeps the HTML-state on "soft" reloads).
Snuffleupagus
force-pushed
the
toolbars-reset
branch
from
7fa6725
to
047522a
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/941662b03d48fb6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/941662b03d48fb6/output.txt Total script time: 2.40 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/32ecb06f4dc9690/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9f4ae62dc2ae4d5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/32ecb06f4dc9690/output.txt Total script time: 4.71 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9f4ae62dc2ae4d5/output.txt Total script time: 8.72 mins
|
By invoking the
resetmethods last in theToolbar/SecondaryToolbar-constructors, we ensure that the "toolbarreset"/"secondarytoolbarreset"-events are actually handle when the viewer loads. Note that previously those events were dispatched before the relevant event-listeners had been attached.With this small change we can avoid inconsistent initial toolbar-state, specifically in the case when the viewer is reloaded (since Firefox keeps the HTML-state on "soft" reloads).