Improve handling of the "Cancel"-button in the password dialog #15341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The password dialog can be cancelled in three different ways: - By clicking on its "Cancel"-button. - By pressing the Escape-key. - By force-opening another dialog, although this shouldn't happen in practice. Here the "Cancel"-button case is slightly special since it'll trigger `PasswordPrompt.#cancel` *twice*, first directly via the click and secondly via the "close" event on the `dialog`-element. While this shouldn't, as far as I know, cause any bugs it's nonetheless inconsistent with the other cases outlined above. To improve this we can simply attempt to *close* the password dialog instead, and then rely on the "close" event to run the `PasswordPrompt.#cancel` method.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1f9f35053018e61/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1f9f35053018e61/output.txt Total script time: 2.07 mins Published |
timvandermeij
approved these changes
Aug 27, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password dialog can be cancelled in three different ways:
Here the "Cancel"-button case is slightly special since it'll trigger
PasswordPrompt.#canceltwice, first directly via the click and secondly via the "close" event on thedialog-element.While this shouldn't, as far as I know, cause any bugs it's nonetheless inconsistent with the other cases outlined above. To improve this we can simply attempt to close the password dialog instead, and then rely on the "close" event to run the
PasswordPrompt.#cancelmethod.