-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that Page.getOperatorList
handles Annotation parsing errors correctly (issue 15557, bug 1794351)
#15558
Conversation
…correctly (issue 15557) *Fixes a regression from PR 15246, sorry about that!* The return value of all `Annotation.getOperatorList` methods was changed in PR 15246, however I missed updating the error code-path in `Page.getOperatorList` which thus breaks all operatorList-parsing for pages with corrupt Annotations.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d134a79a16d1e81/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8d4a96ffa59c479/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d134a79a16d1e81/output.txt Total script time: 25.33 mins
Image differences available at: http://54.241.84.105:8877/d134a79a16d1e81/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8d4a96ffa59c479/output.txt Total script time: 30.14 mins
|
Page.getOperatorList
handles Annotation parsing errors correctly (issue 15557)Page.getOperatorList
handles Annotation parsing errors correctly (issue 15557, bug 1794351)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/510cd7237fa5bc8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/76e849b8e99e923/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/510cd7237fa5bc8/output.txt Total script time: 21.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/76e849b8e99e923/output.txt Total script time: 22.60 mins
|
Fixes a regression from PR #15246, sorry about that!
The return value of all
Annotation.getOperatorList
methods was changed in PR #15246, however I missed updating the error code-path inPage.getOperatorList
which thus breaks all operatorList-parsing for pages with corrupt Annotations.