-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the /Pages dictionary /Count check for corrupt documents (issue 9105) #15593
Conversation
… 9105) After PR 14311, and follow-up patches, we no longer require that the /Count entry (in the /Pages dictionary) is either present or even valid in order to parse/render a PDF document. Hence it seems strange to keep this requirement for *corrupt* PDF documents, when trying to find a usable `trailer` in the `XRef.indexObjects` method.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d20527dd2989636/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/90c585faab8e3be/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/90c585faab8e3be/output.txt Total script time: 24.88 mins
Image differences available at: http://54.241.84.105:8877/90c585faab8e3be/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d20527dd2989636/output.txt Total script time: 29.59 mins
Image differences available at: http://54.193.163.58:8877/d20527dd2989636/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/92e1d4b45d45bd0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/ebdc6ec92af2c2b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/92e1d4b45d45bd0/output.txt Total script time: 21.38 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ebdc6ec92af2c2b/output.txt Total script time: 22.79 mins
|
After PR #14311, and follow-up patches, we no longer require that the /Count entry (in the /Pages dictionary) is either present or even valid in order to parse/render a PDF document.
Hence it seems strange to keep this requirement for corrupt PDF documents, when trying to find a usable
trailer
in theXRef.indexObjects
method.Fixes #9105 (comment)