-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editor tests on Windows #15623
Fix editor tests on Windows #15623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with one suggestion and with passing tests; thank you!
24e266b
to
8d7aaa7
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/37c73cedab0c89f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/507f222e846f35e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/37c73cedab0c89f/output.txt Total script time: 4.15 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/507f222e846f35e/output.txt Total script time: 10.32 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ac681056814812b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f001990448daa2b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ac681056814812b/output.txt Total script time: 4.08 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f001990448daa2b/output.txt Total script time: 10.31 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c97d98a4c72ba7c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f8a3f1525870720/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c97d98a4c72ba7c/output.txt Total script time: 4.18 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f8a3f1525870720/output.txt Total script time: 9.70 mins
|
8d7aaa7
to
e8c2165
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ee5d0f1d8c23f0e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0d23122b5ae2a94/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ee5d0f1d8c23f0e/output.txt Total script time: 4.60 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0d23122b5ae2a94/output.txt Total script time: 9.17 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b04e870ef4ec9d2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d801c0b146ada4c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b04e870ef4ec9d2/output.txt Total script time: 4.18 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d801c0b146ada4c/output.txt Total script time: 9.78 mins
|
- In mozilla#15373, we implemented copy/paste actions in using the system clipboard. For any reasons, on Windows, the clipboard doesn't contain the expected data when the tests are ran in parallel, hence the tests which are using the clipboard need to be ran sequentially. - Make sure that we can paste after having copied.
e8c2165
to
2384fbc
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/39d95697a0f7dd2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/42c4d12faaeba01/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/42c4d12faaeba01/output.txt Total script time: 4.13 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/39d95697a0f7dd2/output.txt Total script time: 9.92 mins
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/51a7843d890ef84/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/54883c709b242e1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/54883c709b242e1/output.txt Total script time: 4.09 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/51a7843d890ef84/output.txt Total script time: 9.85 mins
|
I think windows tests are in a better shape with this patch. |
Agreed, it seems like it helped on the bots. (It's weird that these problems don't show up locally...)
Do you have time to continue investigating this in #15308?
Agreed, but since this is only in tests I suppose it's not that bad overall.
Sure (I looked at the changes and it seems fine). |
I'll try to find some time this week or the week after. |
For any reasons, on Windows, the clipboard doesn't contain the expected data when the tests are ran in parallel, hence the tests which are using the clipboard need to be ran sequentially.