Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Take all the viewBox into account when computing the coordinates of an annotation in the page (fixes #15789) #15791

Merged
merged 1 commit into from
Dec 8, 2022
Merged

[Editor] Take all the viewBox into account when computing the coordinates of an annotation in the page (fixes #15789) #15791

merged 1 commit into from
Dec 8, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@Snuffleupagus
Copy link
Collaborator

This looks fine to me, modulo the comments in PR #15782 being addressed first.

@Snuffleupagus Snuffleupagus linked an issue Dec 8, 2022 that may be closed by this pull request
Annotations are on Wrong Position after Saving/Downloading #15789
Closed
@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/319fd2944d611ad/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c2d4e789cd4c229/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/319fd2944d611ad/output.txt

Total script time: 4.22 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

I was expecting this failure but I had the secret hope that it could work.

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c2d4e789cd4c229/output.txt

Total script time: 11.02 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d24ee596a047625/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/69b42e5278e69bc/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d24ee596a047625/output.txt

Total script time: 4.15 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 8, 2022

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/69b42e5278e69bc/output.txt

Total script time: 10.69 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman calixteman merged commit baff5ad into mozilla:master Dec 8, 2022
@calixteman calixteman deleted the 15789 branch December 8, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations are on Wrong Position after Saving/Downloading
3 participants
@calixteman @Snuffleupagus @pdfjsbot