A little clean-up of the getDocument call in test/driver.js
#16054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the `URL`-object directly to `getDocument`, since that's been supported since PR 13166. - Remove support for the `disableRange`-option in the test-manifest, since it's completely unused. Please note that it's originally added in PR 2719, however there's never actually been any reference tests using it (not even from the start). Given that the option is `false` by default everywhere (e.g. in the Firefox PDF Viewer) and that we have unit-tests for `disableRange = true`, it doesn't seem necessary to add new reference tests for it now.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/486ad7b921eb3db/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8c3446069f2e5e7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/486ad7b921eb3db/output.txt Total script time: 20.74 mins
Image differences available at: http://54.241.84.105:8877/486ad7b921eb3db/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8c3446069f2e5e7/output.txt Total script time: 22.92 mins
Image differences available at: http://54.193.163.58:8877/8c3446069f2e5e7/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Feb 19, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL-object directly togetDocument, since that's been supported since PR [api-minor] Support properURL-objects, in addition to URL-strings, ingetDocument#13166.disableRange-option in the test-manifest, since it's completely unused. Please note that it's originally added in PR Implement progressive loading of PDFs #2719, however there's never actually been any reference tests using it (not even from the start). Given that the option isfalseby default everywhere (e.g. in the Firefox PDF Viewer) and that we have unit-tests fordisableRange = true, it doesn't seem necessary to add new reference tests for it now.