Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more visible color for selected thumbnails (bug 1690428) #16132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

calixteman
Copy link
Contributor

In HCM, the thumbnail ring wasn't visible at all.

In HCM, the thumbnail ring wasn't visible at all.
@calixteman calixteman requested a review from Snuffleupagus March 8, 2023 18:57
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Mar 8, 2023

In HCM, the thumbnail ring wasn't visible at all.

Did you actually mean to limit this to that mode? As-is this also affects the "regular" light/dark theme where it looks really out of place (and dare I say quite bad).
Furthermore, this color is also used in the outline and there this really doesn't work at all (it's especially bad in the light theme).

@calixteman
Copy link
Contributor Author

In Firefox it seems that it's the color we use to outline:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/global-shared.css#19

And I agree with you but in the meantime I agree with Mats (who filed the bug) either.
I'm using myself a dark mode and there is this blue line which doesn't really hurt me:
image
image

I thought that it's better to use the same kind of color everywhere because the user is used to them.

We can limit the change to HCM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants