Compatible with ResizeObserver borderBoxSize in legacy safari #16311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
requested changes
Apr 18, 2023
There was a problem hiding this comment.
I'm guessing that this is specifically for Safari-compatibility[1], since the commit message doesn't actually say which browser(s) are affected?
Hence, when updating the patch, please squash the commits and also improve the commit message.
[1] Based on https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support and https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserverEntry/borderBoxSize#browser_compatibility
linxianxi
force-pushed
the
fix-viewer-browser-compatibility
branch
from
004f7cf to
19eb845
Compare
linxianxi
changed the title
linxianxi
changed the title
linxianxi
force-pushed
the
fix-viewer-browser-compatibility
branch
3 times, most recently
from
2106eec to
2ac1b2f
Compare
linxianxi
force-pushed
the
fix-viewer-browser-compatibility
branch
from
f95b464 to
6ca702d
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6417634311a9ab9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6417634311a9ab9/output.txt Total script time: 1.29 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs:
https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserverEntry/borderBoxSize#browser_compatibility
error:
