Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access the isOffscreenCanvasSupported option *once* in PDFViewerApplication._initializeViewerComponents #16683

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

There's no good reason for getting this option multiple times in the same method. Also, we can slightly re-factor how the editorStampButton is made visible.

…plication._initializeViewerComponents`

There's no good reason for getting this option multiple times in the same method. Also, we can slightly re-factor how the `editorStampButton` is made visible.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0bdd4d51ff264c2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0bdd4d51ff264c2/output.txt

Total script time: 1.36 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 762d86a into mozilla:master Jul 12, 2023
@Snuffleupagus Snuffleupagus deleted the app-isOffscreenCanvasSupported branch July 12, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants