Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Always use the data url when loading a SVG in order to avoid CSP issue (bug 1843255) #16686

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Editor] Always use the data url when loading a SVG in order to avoid CSP issue (bug 1843255) #16686

merged 1 commit into from
Jul 13, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@Snuffleupagus
Copy link
Collaborator

This is perhaps more of an existing "problem", but shouldn't fileReader and imageElement implement onerror-functions (that reject the imagePromise) such that we cannot accidentally leave this code in a perpetually pending state?

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c998b38daf0f3f0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bafca0bd10b4fba/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/c998b38daf0f3f0/output.txt

Total script time: 5.01 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bafca0bd10b4fba/output.txt

Total script time: 12.76 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 36fc34e into mozilla:master Jul 13, 2023
3 checks passed
@calixteman calixteman deleted the bug1843255 branch July 13, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @Snuffleupagus @moz-tools-bot