-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't uselessly change the filter when drawing (bug 1508765) #16722
Conversation
Should we perhaps do the same thing in e.g. the following code as well? Line 793 in a079f9c
|
When profiling the pdf in https://bugzilla.mozilla.org/show_bug.cgi?id=1508765, I noticed that half a second was spent to set the filter to "none".
a079f9c
to
9a4750f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/439d2d9829418d0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/9639e17945ad0d3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/439d2d9829418d0/output.txt Total script time: 25.11 mins
Image differences available at: http://54.241.84.105:8877/439d2d9829418d0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9639e17945ad0d3/output.txt Total script time: 38.71 mins
Image differences available at: http://54.193.163.58:8877/9639e17945ad0d3/reftest-analyzer.html#web=eq.log |
When profiling the pdf in https://bugzilla.mozilla.org/show_bug.cgi?id=1508765, I noticed that half a second was spent to set the filter to "none".