[GeckoView] Fix string for download button #16726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #16701 (comment) I really think that we should ask UI to reconsider the string instead, both for consistency between the viewers and because of the fact that "Save" is technically more correct since the PDF was (generally) already downloaded when this button is clicked. |
|
For now, we must revert to the previous state and fix the l10 issue in order to not break fenix. |
flodolo
reviewed
Jul 22, 2023
In PR #16340, I forgot to add the string (the one for Download) in the localization file. |
calixteman
force-pushed
the
gv_fix_dl_button
branch
from
bd99520
to
708b0f5
Compare
flodolo
approved these changes
Jul 22, 2023
calixteman
force-pushed
the
gv_fix_dl_button
branch
from
708b0f5
to
74642b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.