Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Make editors movable in using the keyboard (bug 1845088) #16746

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[Editor] Make editors movable in using the keyboard (bug 1845088) #16746

merged 1 commit into from
Jul 26, 2023

Conversation

calixteman
Copy link
Contributor

Selected editors can be moved in using the arrows:

  • up/down/left/right will move the editors of 1 in page unit;
  • ctrl (or meta)+up/down/left/right will move them of 10 in page unit.

Snuffleupagus
Snuffleupagus reviewed Jul 26, 2023
View reviewed changes
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/shared/util.js Outdated Show resolved Hide resolved
src/display/editor/tools.js Show resolved Hide resolved
src/display/editor/tools.js Outdated Show resolved Hide resolved
test/integration/test_utils.js Outdated Show resolved Hide resolved
@Snuffleupagus
Copy link
Collaborator

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/15a9d3f1b058664/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/61eed80b7820971/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/15a9d3f1b058664/output.txt

Total script time: 4.66 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/61eed80b7820971/output.txt

Total script time: 18.03 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator

It seems that the must serialize invisible annotations test now fails consistently.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/05e738d99aa9133/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/26b757faa5660e2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/05e738d99aa9133/output.txt

Total script time: 4.79 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/26b757faa5660e2/output.txt

Total script time: 16.94 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the final comments addressed; thank you!

test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved
test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved
test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved
@calixteman
[Editor] Make editors movable in using the keyboard (bug 1845088)
bb6936c 
Selected editors can be moved in using the arrows:
 - up/down/left/right will move the editors of 1 in page unit;
 - ctrl (or meta)+up/down/left/right will move them of 10 in page unit.
@calixteman calixteman merged commit 7f634e4 into mozilla:master Jul 26, 2023
3 checks passed
@calixteman calixteman deleted the editor_keyboard_movable branch July 26, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @Snuffleupagus @moz-tools-bot