Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of buttons in the toolbar in HCM (bug 1845515) #16748

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

calixteman
Copy link
Contributor

With this patch, in HCM, make a button visible when it's active and add an outline around toggled buttons when they're hovered.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, and please make sure to carefully test the viewer since these sort of changes can very easily "break" a bunch of (unintended) things.

web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
With this patch, in HCM, make a button visible when it's active and
add an outline around toggled buttons when they're hovered.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, since this is now limited to only HCM mode; thank you!

(Possibly we should re-factor all button-colors/outlines/hover/... but that should happen separately, such that everything is covered and changed all at once if so.)

@calixteman calixteman merged commit a2eca47 into mozilla:master Jul 26, 2023
3 checks passed
@calixteman calixteman deleted the hcm_toolbar_button branch July 26, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants