Enable the unicorn/prefer-ternary ESLint plugin rule

[Snuffleupagus]

• Enable the unicorn/prefer-ternary ESLint plugin rule

  To limit the readability impact of these changes, the only-single-line option was used; please find additional details at https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-ternary.md

  These changes were done automatically, using the gulp lint --fix command.

• Additional manual unicorn/prefer-ternary changes

  Not all cases could be automatically fixed, and the changes also triggered a number of prefer-const errors that needed to be handled manually.

[Snuffleupagus]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/464b3059b3b91fb/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/17abb9d0aabfefe/output.txt

[calixteman]

LGTM. Thank you.

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/464b3059b3b91fb/output.txt

Total script time: 27.13 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/464b3059b3b91fb/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/17abb9d0aabfefe/output.txt

Total script time: 37.57 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  errors: 1
  different ref/snapshot: 33
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/17abb9d0aabfefe/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

/botio-linux integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/286a43c0460c43c/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/286a43c0460c43c/output.txt

Total script time: 4.75 mins

• Integration Tests: FAILED