Ignore null-chars when using structTree-data in the viewer #16891
Conversation
|
I wonder if we should strip out null chars in the worker instead of doing it in the main thread. |
In that case we really ought to change "everything" all at once, in my opinion, rather than doing it piecemeal. |
|
What do you mean by "everything" ? |
Looking at the |
Snuffleupagus
force-pushed
the
structElement-removeNullCharacters
branch
from
677e304
to
83f5ca9
Compare
Testing the `tagged_stamp.pdf` document locally in the viewer, I noticed that e.g. the /Alt entry for the StampAnnotation contains "Secondary text for stamp\u0000". Elsewhere in the viewer we're skipping null-chars and it's easy enough to do that in the `StructTreeLayerBuilder` class as well. (Note that we generally let the API itself return the data as-is.)
Snuffleupagus
force-pushed
the
structElement-removeNullCharacters
branch
from
83f5ca9
to
284f32f
Compare
|
Now with an integration-test added, to prevent this from regressing. /botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3c67bfa4414faad/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e1aaf33b22cf0fb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e1aaf33b22cf0fb/output.txt Total script time: 5.19 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3c67bfa4414faad/output.txt Total script time: 16.11 mins
|
Testing the
tagged_stamp.pdfdocument locally in the viewer, I noticed that e.g. the /Alt entry for the StampAnnotation contains "Secondary text for stamp\u0000".Elsewhere in the viewer we're skipping null-chars and it's easy enough to do that in the
StructTreeLayerBuilderclass as well. (Note that we generally let the API itself return the data as-is.)