Commits on Sep 12, 2023

1. Ensure that the entire PDF document is loaded *before* we begin savin… …

   …g it
   
   When I started looking at PR 16938 it occurred to me that some of the new structTree-methods are synchronously accessing certain dictionary-data (not used during "normal" structTree-parsing), which may not be generally safe since everything in a dictionary could be a reference (and the relevant data may not have been loaded yet).
   
   Rather than suggesting that we make all those new methods even more asynchronous, to me the overall simplest and safest solution is to ensure that the *entire* PDF document has been loaded *before* we begin saving it. In practice this shouldn't really affect "performance" of saving noticeably, since it's always depended on the entire PDF document being downloaded.
   
   Finally note that with the exception of the PDF document possibly not having been fully downloaded when saving is triggered, all other "global" document properties are pretty much guaranteed to already be available at this point.

   

   Snuffleupagus committed Sep 12, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 50937a3
   • Browse repository at this point

   Copy the full SHA

   50937a3 View commit details

   Browse the repository at this point in the history