[Editor] Change the style of the bounding box and the resizers (bug 1852897) #16943
Conversation
There was a problem hiding this comment.
Quick testing reveals at least two problems:
- When enabling Ink-editing and hovering over a page, before you begin drawing, the dashed outline in now wider and longer than the page. Besides looking strange, this means that it's now possible to draw outside of the page.
- The dashed outline for a non-focused editor now has a larger size than the outline of a focused editor, which means that when selecting an editor (via clicking) the outline now "shrinks" which wasn't the case before (and it feels a bit jarring).
calixteman
force-pushed
the
new_resizers
branch
from
91c79cd
to
ee3f3c3
Compare
calixteman
force-pushed
the
new_resizers
branch
from
ee3f3c3
to
38457ae
Compare
This problem is still reproducible when rotating the PDF document to any non-zero value. |
calixteman
force-pushed
the
new_resizers
branch
from
38457ae
to
5b70650
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/55e3f492582b84c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/55e3f492582b84c/output.txt Total script time: 1.46 mins Published |
calixteman
force-pushed
the
new_resizers
branch
from
5b70650
to
a919a66
Compare
|
I was ready to approve this, but it seems that the latest update removed a bit too much code :-) |
calixteman
force-pushed
the
new_resizers
branch
from
a919a66
to
01f9f38
Compare
There was a problem hiding this comment.
It's quite unfortunate that the solution needed to be this "complex", but hopefully we can simplify this once bug 1848458 is implemented.
r=me, since this seems to work correctly now; thank you!
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7fe20eb92fa1543/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/79ee1627271dd6e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7fe20eb92fa1543/output.txt Total script time: 4.61 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/79ee1627271dd6e/output.txt Total script time: 18.49 mins
|
No description provided.