[Editor] Add a dialog box in order to get alt-text data (bug 1844952)

[calixteman]

Implements the specifications provided by UX for light, dark and HCM modes.

[Snuffleupagus]

As far as I can tell there's nothing that actually displays this dialog, since there's no JS-code included in the patch, so how would you actually test this?

[calixteman]

To just display it: in the console, document.getElementById("altTextDialog").showModal().
We want to have this patch (and another one with a button to trigger this dialog) asap in m-c in order to start the translation of the strings asap.

[flodolo]

There still seems to be discussions over the copy in the doc? I see unresolved comments.

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2c5f5ce81102f13/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/2c5f5ce81102f13/output.txt

Total script time: 1.45 mins

Published

• Viewer: http://54.241.84.105:8877/2c5f5ce81102f13/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/2c5f5ce81102f13/legacy/web/viewer.html

[Snuffleupagus]

Unfortunately I'm no longer able to access the Figma link in https://bugzilla.mozilla.org/show_bug.cgi?id=1844952#c12, since I'm now taken to a login page, so I can't really check that the implementation matches the specification.

[Snuffleupagus]

No longer being able to access the specification, as mentioned above, one question based on testing the preview:
Do we need to have this much total padding in the dialog, since here we get the padding of all dialog-elements from

pdf.js/web/viewer.css

Line 1291 in 9781989

padding: 15px;

plus the new padding added in

pdf.js/web/annotation_editor_layer_builder.css

Line 407 in da52f2e

padding: 12px 16px;

and it's not entirely clear to me if it needs to be that much?

[calixteman]

No longer being able to access the specification, as mentioned above, one question based on testing the preview: Do we need to have this much total padding in the dialog, since here we get the padding of all dialog-elements from

pdf.js/web/viewer.css

Line 1291 in 9781989

padding: 15px;

plus the new padding added in

pdf.js/web/annotation_editor_layer_builder.css

Line 407 in da52f2e

padding: 12px 16px;

and it's not entirely clear to me if it needs to be that much?

Good catch, thank you.

[Snuffleupagus]

Did the latest version of the patch accidentally revert the fix for #16952 (comment)?

[Snuffleupagus]

Also, testing the preview above it seems that the descriptionTextarea textArea has both a border and an outline when focused, and the specification seems to suggest that only the border color should change in that case?

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f04dc70956e505d/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/f04dc70956e505d/output.txt

Total script time: 1.51 mins

Published

• Viewer: http://54.241.84.105:8877/f04dc70956e505d/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/f04dc70956e505d/legacy/web/viewer.html

[Snuffleupagus]

When clicking on the radio-buttons (or the regular buttons) the focus-outline is displayed, do we want that or should it only apply when using the keyboard?

[calixteman]

When clicking on the radio-buttons (or the regular buttons) the focus-outline is displayed, do we want that or should it only apply when using the keyboard?

I used focus-visible and I switched to focus when I played with some radios in the network settings in prefs: focus outline is shown when the radio are clicked, so I just did the same.

[Snuffleupagus]

I used focus-visible and I switched to focus when I played with some radios in the network settings in prefs: focus outline is shown when the radio are clicked, so I just did the same.

Sure, that seems fine regarding the radio-buttons. However, it also happens when clicking the Cancel/Save buttons in the dialog which isn't the case for buttons in about:preferences.

[Snuffleupagus]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/05e905489b6bf67/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/05e905489b6bf67/output.txt

Total script time: 2.49 mins

Published

• Viewer: http://54.241.84.105:8877/05e905489b6bf67/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/05e905489b6bf67/legacy/web/viewer.html

[Snuffleupagus]

r=me, since this now seems to agree with the specification; thank you!