Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Avoid to have some transparency in the icon used in the 'Alt text' button #16972

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[Editor] Avoid to have some transparency in the icon used in the 'Alt text' button #16972

merged 1 commit into from
Sep 18, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

The difference:
image
image

is very subtle (it's more obvious when the done class is applied to the button) but it exists (there is a gray pixel close to the center of the plus sign).

Snuffleupagus
Snuffleupagus approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it's more obvious when the done class is applied to the button)

This is kind of funny, since I actually noticed that while testing but apparently forgot to mention it during review :-)

r=me, thank you!

@calixteman calixteman merged commit 2bd7bb3 into mozilla:master Sep 18, 2023
3 checks passed
@calixteman calixteman deleted the alt_text_icon_alpha branch September 18, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixteman @Snuffleupagus