Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new "reporttelemetry" event in more viewer components #16989

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

By utilizing the recently added "reporttelemetry" event, we can avoid having to manually pass in externalServices to a number of viewer components.

By utilizing the recently added "reporttelemetry" event, we can avoid having to manually pass in `externalServices` to a number of viewer components.
@Snuffleupagus Snuffleupagus changed the title Use the new "reporttelemetry" in more viewer components Use the new "reporttelemetry" event in more viewer components Sep 20, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/873271418017417/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/873271418017417/output.txt

Total script time: 1.57 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 34506f8 into mozilla:master Sep 20, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the more-reporttelemetry-event branch September 20, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants